Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returns InvalidToken if scanner encounters error #486

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Returns InvalidToken if scanner encounters error #486

merged 1 commit into from
Oct 29, 2024

Conversation

goccy
Copy link
Owner

@goccy goccy commented Oct 29, 2024

  • Refactor scanner package

    • Support InvalidTokenError for scanner
    • Update sourcePos by scanning functions side
  • Support token.InvalidToken

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 74.53416% with 41 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@c7e80a3). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #486   +/-   ##
=========================================
  Coverage          ?   77.69%           
=========================================
  Files             ?       18           
  Lines             ?     5865           
  Branches          ?        0           
=========================================
  Hits              ?     4557           
  Misses            ?     1035           
  Partials          ?      273           

@goccy goccy merged commit 87ddfd1 into master Oct 29, 2024
18 checks passed
@goccy goccy deleted the scanner branch October 29, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants